Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: Source/modules/webaudio/AsyncAudioDecoder.h

Issue 1006963003: AudioContext.decodeAudioData returns a Promise (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Error callback invoked with error, not null. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AsyncAudioDecoder.h
diff --git a/Source/modules/webaudio/AsyncAudioDecoder.h b/Source/modules/webaudio/AsyncAudioDecoder.h
index 8e39cb74b730f907edea2a3f63f0a8aa72b19e85..a932e74652b70535daff1b92713da9ddb7c68647 100644
--- a/Source/modules/webaudio/AsyncAudioDecoder.h
+++ b/Source/modules/webaudio/AsyncAudioDecoder.h
@@ -34,7 +34,9 @@ namespace blink {
class AudioBuffer;
class AudioBufferCallback;
class AudioBus;
+class AudioContext;
class DOMArrayBuffer;
+class ScriptPromiseResolver;
// AsyncAudioDecoder asynchronously decodes audio file data from a DOMArrayBuffer in a worker thread.
// Upon successful decoding, a completion callback will be invoked with the decoded PCM data in an AudioBuffer.
@@ -46,14 +48,15 @@ public:
~AsyncAudioDecoder();
// Must be called on the main thread.
- void decodeAsync(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback);
+ void decodeAsync(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolver*, AudioContext*);
private:
AudioBuffer* createAudioBufferFromAudioBus(AudioBus*);
- static void decode(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback);
- static void notifyComplete(DOMArrayBuffer* audioData, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, AudioBus*);
+ static void decode(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolver*, AudioContext*);
+ static void notifyComplete(DOMArrayBuffer* audioData, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, AudioBus*, ScriptPromiseResolver*, AudioContext*);
OwnPtr<WebThread> m_thread;
+ RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
haraken 2015/04/07 23:39:14 Since AsyncAudioDecoder is not on-heap, this needs
Raymond Toy 2015/04/08 16:47:11 Oops. This isn't actually used anywhere. Deleting
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698