LayoutTests/webaudio/decode-audio-data-basic-expected.txt - Issue 1006963003: AudioContext.decodeAudioData returns a Promise

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webaudio/decode-audio-data-basic-expected.txt

Issue 1006963003: AudioContext.decodeAudioData returns a Promise (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix idl; small cleanups Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/webaudio/decode-audio-data-basic.html ('K') | « LayoutTests/webaudio/decode-audio-data-basic.html ('k') | LayoutTests/webaudio/decode-audio-data-promise.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 CONSOLE ERROR: line 21: Uncaught (in promise) NotSupportedError: invalid ArrayBu ffer for audioData.
	hongchan 2015/03/23 16:18:49 We don't want this kind of error messages in the e We don't want this kind of error messages in the expected result. Do we? Raymond Toy 2015/03/23 18:45:20 I'm undecided. I kind of didn't want to write dec Show quoted text On 2015/03/23 16:18:49, hoch wrote: > We don't want this kind of error messages in the expected result. Do we? I'm undecided. I kind of didn't want to write decodeAudioData().then(), because it's not required, even if promises are supported. But it's also annoying to have that in the expected result.
1 Basic tests for decodeAudioData function.	2 Basic tests for decodeAudioData function.

2	3

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	4 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4	5

5	6

6 PASS decodeAudioData raises exception correctly when arraybuffer parameter is nu ll.	7 PASS decodeAudioData(null) invoked errorCallback correctly.

7 PASS The resources/media/24bit-44khz.wav test: successCallback has been called c orrectly.	8 PASS The resources/media/24bit-44khz.wav test: successCallback has been called c orrectly.

8 PASS The resources/media/invalid-audio-file.txt test: errorCallback has been cal led correctly.	9 PASS The resources/media/invalid-audio-file.txt test: errorCallback has been cal led correctly.

9 PASS successfullyParsed is true	10 PASS successfullyParsed is true

10	11

11 TEST COMPLETE	12 TEST COMPLETE

12	13

OLD	NEW