Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1006913004: Add screenshots to networking.config documentation. (Closed)

Created:
5 years, 9 months ago by pneubeck (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add screenshots to networking.config documentation. BUG=432280 Committed: https://crrev.com/b7508b9f00ef5f6d4c626ac50aad49627cb90044 Cr-Commit-Position: refs/heads/master@{#321967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
A chrome/common/extensions/docs/static/images/networking_config_badge.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/networking_config_notification.png View Binary file 0 comments Download
M chrome/common/extensions/docs/templates/intros/networking_config.html View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
pneubeck (no reviews)
As requested by Benjamin Kalman, this adds screenshots for the UI effects of the API. ...
5 years, 9 months ago (2015-03-24 10:41:01 UTC) #2
Mike West
On 2015/03/24 at 10:41:01, pneubeck wrote: > As requested by Benjamin Kalman, this adds screenshots ...
5 years, 9 months ago (2015-03-24 10:45:33 UTC) #3
pneubeck (no reviews)
On 2015/03/24 10:45:33, Mike West wrote: > On 2015/03/24 at 10:41:01, pneubeck wrote: > > ...
5 years, 9 months ago (2015-03-24 10:47:38 UTC) #4
Mike West
On 2015/03/24 at 10:47:38, pneubeck wrote: > On 2015/03/24 10:45:33, Mike West wrote: > > ...
5 years, 9 months ago (2015-03-24 10:48:48 UTC) #5
pneubeck (no reviews)
On 2015/03/24 10:48:48, Mike West wrote: > On 2015/03/24 at 10:47:38, pneubeck wrote: > > ...
5 years, 9 months ago (2015-03-24 10:49:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006913004/1
5 years, 9 months ago (2015-03-24 10:50:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 11:17:38 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 11:19:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7508b9f00ef5f6d4c626ac50aad49627cb90044
Cr-Commit-Position: refs/heads/master@{#321967}

Powered by Google App Engine
This is Rietveld 408576698