Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 10069029: mac: Fix HighDPI mode on 10.7.3 (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Mark Mentovai, dmac
Visibility:
Public.

Description

mac: Fix HighDPI mode on 10.7.3 Apparently omission of the NSPrincipalClass key sends an app down the magnify mode path starting with 10.7.3. Thanks to YAMAMOTO Mitsuharu for figuring this out: http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00052.html BUG=31960 TEST=Start chromium in highdpi mode. Toolbar looks good. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132117

Patch Set 1 #

Total comments: 2

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/app/app-Info.plist View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 8 months ago (2012-04-12 20:45:59 UTC) #1
Mark Mentovai
Hmm. I thought we already had this. LGTM otherwise. http://codereview.chromium.org/10069029/diff/1/chrome/app/app-Info.plist File chrome/app/app-Info.plist (right): http://codereview.chromium.org/10069029/diff/1/chrome/app/app-Info.plist#newcode242 chrome/app/app-Info.plist:242: ...
8 years, 8 months ago (2012-04-12 20:46:43 UTC) #2
Nico
`git log -S NSPrincipalClass chrome/app/app-Info.plist` tells me that we used to have this, but it ...
8 years, 8 months ago (2012-04-12 20:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10069029/4001
8 years, 8 months ago (2012-04-12 21:01:16 UTC) #4
commit-bot: I haz the power
Try job failure for 10069029-4001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-13 00:26:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10069029/4001
8 years, 8 months ago (2012-04-13 00:57:50 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 01:01:04 UTC) #7
Change committed as 132117

Powered by Google App Engine
This is Rietveld 408576698