Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1006833002: Gallery.app : shows an error message when it fails to save an image. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery.app : shows an error message when it fails to save an image. BUG=463837 TEST=manually tested with chaning the code to throw an error in a promise. Committed: https://crrev.com/9ef2a2e3470d7aa04178c0ee3ecb9363ca06c7d1 Cr-Commit-Position: refs/heads/master@{#320854}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed string resource. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yawano
PTAL. Thank you!
5 years, 9 months ago (2015-03-13 08:41:45 UTC) #2
hirono
lgtm, thanks! https://codereview.chromium.org/1006833002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/1006833002/diff/1/chrome/app/chromeos_strings.grdp#newcode359 chrome/app/chromeos_strings.grdp:359: Failed to save an image. Could you ...
5 years, 9 months ago (2015-03-13 08:45:38 UTC) #3
yawano
On 2015/03/13 08:45:38, hirono wrote: > lgtm, thanks! > > https://codereview.chromium.org/1006833002/diff/1/chrome/app/chromeos_strings.grdp > File chrome/app/chromeos_strings.grdp (right): ...
5 years, 9 months ago (2015-03-13 08:51:41 UTC) #4
yawano
https://codereview.chromium.org/1006833002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/1006833002/diff/1/chrome/app/chromeos_strings.grdp#newcode359 chrome/app/chromeos_strings.grdp:359: Failed to save an image. On 2015/03/13 08:45:38, hirono ...
5 years, 9 months ago (2015-03-17 00:54:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006833002/20001
5 years, 9 months ago (2015-03-17 00:55:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 03:18:29 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 03:20:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ef2a2e3470d7aa04178c0ee3ecb9363ca06c7d1
Cr-Commit-Position: refs/heads/master@{#320854}

Powered by Google App Engine
This is Rietveld 408576698