Issue 100683002: Ensure that a fullscreen RenderWidgetHostViewAura instance does not restore itself on Windows when …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100683002: Ensure that a fullscreen RenderWidgetHostViewAura instance does not restore itself on Windows when … (Closed)

Created:
7 years ago by ananta

Modified:
7 years ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ensure that a fullscreen RenderWidgetHostViewAura instance does not restore itself on Windows when we switch away to a different monitor. We have code in RenderWidgetHostViewAura::OnWindowFocused to handle this case. It does this by comparing the display ids of the window being activated and the one losing activation. However in desktop Chrome we could lose activation to a non Aura Window. We handle this case on Windows by getting the cursor position and the display near that and comparing that with the display of the window losing activation. Fixes bug https://code.google.com/p/chromium/issues/detail?id=317532 BUG=317532 R=jam@chromium.org, jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238441

Patch Set 1 #

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r238441 (presubmit successful).

Expand Messages | Collapse Messages