Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1006813015: Add unittest for canonical host override. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unittest for canonical host override. Currently, when adding an alternative service with a new host, that host will become the canonical host (if appropriate), override previous canonical hosts for the same domain. This CL adds a test to document this behavior. BUG=392575 Committed: https://crrev.com/6f210fa8372d05f03450e52d45deb194596b65f1 Cr-Commit-Position: refs/heads/master@{#322356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL, thanks.
5 years, 9 months ago (2015-03-25 15:27:35 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-26 00:24:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006813015/1
5 years, 9 months ago (2015-03-26 11:25:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 11:28:22 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 11:29:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f210fa8372d05f03450e52d45deb194596b65f1
Cr-Commit-Position: refs/heads/master@{#322356}

Powered by Google App Engine
This is Rietveld 408576698