Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1006813013: Cleanup .gitignore file (Closed)

Created:
5 years, 9 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Cleanup .gitignore file Remove extensions that were the present for legacy gyp generators such as make, vsms, and xcode. Remove entries for legacy stuff that has since been removed. Add a leading / for entries that apply to top level items only. Committed: https://chromium.googlesource.com/native_client/src/native_client/+/3ce68ce6bd768ef1c3a6752f97aa11e0fc9ab079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M .gitignore View 3 chunks +8 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Sam Clegg
5 years, 9 months ago (2015-03-24 23:32:22 UTC) #2
bradn
lgtm
5 years, 9 months ago (2015-03-24 23:34:54 UTC) #4
Sam Clegg
On 2015/03/24 23:34:54, bradn wrote: > lgtm Would you mind doing a double-check of thes ...
5 years, 9 months ago (2015-03-24 23:36:07 UTC) #5
bradn
For ninja, that's correct.
5 years, 9 months ago (2015-03-24 23:37:27 UTC) #6
Sam Clegg
On 2015/03/24 23:37:27, bradn wrote: > For ninja, that's correct. And I'm right in thinking ...
5 years, 9 months ago (2015-03-24 23:43:14 UTC) #7
native-client-reviews_googlegroups.com
correct On Tue, Mar 24, 2015 at 4:43 PM, <sbc@chromium.org> wrote: > On 2015/03/24 23:37:27, ...
5 years, 9 months ago (2015-03-24 23:46:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006813013/1
5 years, 9 months ago (2015-03-25 00:14:08 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 02:29:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/3ce68ce6b...

Powered by Google App Engine
This is Rietveld 408576698