src/pdf/SkPDFShader.cpp - Issue 1006813010: SkPDF: Fix leak in SkPDFShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFShader.cpp

Issue 1006813010: SkPDF: Fix leak in SkPDFShader (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFShader.cpp

diff --git a/src/pdf/SkPDFShader.cpp b/src/pdf/SkPDFShader.cpp

index 8fc97da30770153029a1e08fd461adb89e537d9d..97bca73f63b78d33c5e552736e4702f015277646 100644

--- a/src/pdf/SkPDFShader.cpp

+++ b/src/pdf/SkPDFShader.cpp

@@ -877,7 +877,8 @@ SkPDFFunctionShader* SkPDFFunctionShader::Create(

pdfShader->insertName("ColorSpace", "DeviceRGB");

pdfShader->insert("Domain", domain.get());

- SkPDFStream* function = make_ps_function(functionCode, domain.get());

+ SkAutoTUnref<SkPDFStream> function(

+ make_ps_function(functionCode, domain.get()));

pdfShader->insert("Function", new SkPDFObjRef(function))->unref();

SkAutoTUnref<SkPDFArray> matrixArray(

« no previous file with comments | « no previous file | no next file » | no next file with comments »