chrome/browser/ui/search/search_tab_helper.h - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.h

diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h

index 8675c74295c0803c57c9a55ea2bdbcc42db61172..ddf072ee0374aaeb983594a3ecc2e35d7ba54982 100644

--- a/chrome/browser/ui/search/search_tab_helper.h

+++ b/chrome/browser/ui/search/search_tab_helper.h

@@ -171,7 +171,7 @@ class SearchTabHelper : public content::WebContentsObserver,

void OnDeleteMostVisitedItem(const GURL& url) override;

void OnUndoMostVisitedDeletion(const GURL& url) override;

void OnUndoAllMostVisitedDeletions() override;

- void OnLogEvent(NTPLoggingEventType event) override;

+ void OnLogEvent(NTPLoggingEventType event, uint64 time) override;

void OnLogMostVisitedImpression(int position,

const base::string16& provider) override;

void OnLogMostVisitedNavigation(int position,