chrome/browser/ui/search/search_tab_helper_unittest.cc - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper_unittest.cc

diff --git a/chrome/browser/ui/search/search_tab_helper_unittest.cc b/chrome/browser/ui/search/search_tab_helper_unittest.cc

index 6f2b8b7876bd014e85fe47dd33be9f9e06bc8b7f..9855cc4872301d34d61a40f95eb3167393a6d8cc 100644

--- a/chrome/browser/ui/search/search_tab_helper_unittest.cc

+++ b/chrome/browser/ui/search/search_tab_helper_unittest.cc

@@ -8,6 +8,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/metrics/field_trial.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/time/time.h"

#include "chrome/browser/prerender/prerender_manager.h"

#include "chrome/browser/prerender/prerender_manager_factory.h"

#include "chrome/browser/search/instant_unittest_base.h"

@@ -60,7 +61,8 @@ class MockSearchIPCRouterDelegate : public SearchIPCRouter::Delegate {

MOCK_METHOD1(OnDeleteMostVisitedItem, void(const GURL& url));

MOCK_METHOD1(OnUndoMostVisitedDeletion, void(const GURL& url));

MOCK_METHOD0(OnUndoAllMostVisitedDeletions, void());

- MOCK_METHOD1(OnLogEvent, void(NTPLoggingEventType event));

+ MOCK_METHOD2(OnLogEvent, void(NTPLoggingEventType event,

+ base::TimeDelta time));

MOCK_METHOD2(OnLogMostVisitedImpression,

void(int position, const base::string16& provider));

MOCK_METHOD2(OnLogMostVisitedNavigation,