Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_ipc_router.h
diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h
index c2b3513fbc3b269522fc62ac95741619c47465e1..899bdcd0f3c955e456824c301341295ef6485aa4 100644
--- a/chrome/browser/ui/search/search_ipc_router.h
+++ b/chrome/browser/ui/search/search_ipc_router.h
@@ -9,6 +9,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
+#include "base/time/time.h"
#include "chrome/common/instant_types.h"
#include "chrome/common/ntp_logging_events.h"
#include "chrome/common/omnibox_focus_state.h"
@@ -59,8 +60,10 @@ class SearchIPCRouter : public content::WebContentsObserver {
// Called when the SearchBox wants to undo all Most Visited deletions.
virtual void OnUndoAllMostVisitedDeletions() = 0;
- // Called to signal that an event has occurred on the New Tab Page.
- virtual void OnLogEvent(NTPLoggingEventType event) = 0;
+ // Called to signal that an event has occurred on the New Tab Page at a
+ // particular time since navigation start.
+ virtual void OnLogEvent(NTPLoggingEventType event,
+ base::TimeDelta time) = 0;
// Called to log an impression from a given provider on the New Tab Page.
virtual void OnLogMostVisitedImpression(int position,
@@ -206,7 +209,9 @@ class SearchIPCRouter : public content::WebContentsObserver {
void OnDeleteMostVisitedItem(int page_seq_no, const GURL& url) const;
void OnUndoMostVisitedDeletion(int page_seq_no, const GURL& url) const;
void OnUndoAllMostVisitedDeletions(int page_seq_no) const;
- void OnLogEvent(int page_seq_no, NTPLoggingEventType event) const;
+ void OnLogEvent(int page_seq_no,
+ NTPLoggingEventType event,
+ base::TimeDelta time) const;
void OnLogMostVisitedImpression(int page_seq_no,
int position,
const base::string16& provider) const;
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698