chrome/common/render_messages.h - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/render_messages.h

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/render_messages.h

diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h

index 4a000c6a3cd65ec0ad1925bedb83dc3777eed712..9473020b69251315ec14a62b250812bee08ddd34 100644

--- a/chrome/common/render_messages.h

+++ b/chrome/common/render_messages.h

@@ -591,9 +591,10 @@ IPC_MESSAGE_ROUTED4(ChromeViewHostMsg_DidRetrieveMetaTagContent,

#endif // defined(OS_ANDROID)

// Logs events from InstantExtended New Tab Pages.

-IPC_MESSAGE_ROUTED2(ChromeViewHostMsg_LogEvent,

+IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_LogEvent,

int /* page_seq_no */,

- NTPLoggingEventType /* event */)

+ NTPLoggingEventType /* event */,

+ int64 /* time */)

Will Harris 2015/03/16 17:39:03 delta should always be positive, can this be a uin

fserb 2015/03/16 17:49:38 Done.

// Logs an impression on one of the Most Visited tile on the InstantExtended

// New Tab Page.