chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc - Issue 1006753003: Add time from navigation_start to NTP LogEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

Issue 1006753003: Add time from navigation_start to NTP LogEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

index dc53a4c6fb238fde4779eae33e8c627e81f0489c..35f90b67ef4dccbfc9c5e942c4f0e85dad7b7476 100644

--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

@@ -127,7 +127,7 @@ void NTPUserDataLogger::EmitNtpStatistics() {

}

-void NTPUserDataLogger::LogEvent(NTPLoggingEventType event) {

+void NTPUserDataLogger::LogEvent(NTPLoggingEventType event, uint64 time) {

Dan Beam 2015/03/17 17:17:19 why do you ask for this if it's not used...?

fserb 2015/03/17 17:41:31 I've split the change in two: https://codereview.c

switch (event) {

case NTP_SERVER_SIDE_SUGGESTION:

has_server_side_suggestions_ = true;