Add time from navigation_start to NTP LogEvent

chrome/renderer/searchbox/searchbox.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox.h"
 
 #include <string>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/favicon/favicon_url_parser.h"
 #include "chrome/common/omnibox_focus_state.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 #include "components/favicon_base/favicon_types.h"
+#include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "net/base/escape.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebPerformance.h"
 #include "third_party/WebKit/public/web/WebView.h"
 #include "url/gurl.h"
 
 namespace {
 
 // The size of the InstantMostVisitedItem cache.
 const size_t kMaxInstantMostVisitedItemCacheSize = 100;
 
 // Returns true if items stored in |old_item_id_pairs| and |new_items| are
 // equal.
@@ skipping 116 matching lines @@
     display_instant_results_(false),
     most_visited_items_cache_(kMaxInstantMostVisitedItemCacheSize),
     query_(),
     start_margin_(0) {
 }
 
 SearchBox::~SearchBox() {
 }
 
 void SearchBox::LogEvent(NTPLoggingEventType event) {
+  // navigation_start in ms.
+  uint64 start = 1000 *
+                render_view()
+                    ->GetMainRenderFrame()
+                    ->GetWebFrame()
+                    ->performance()
+                    .navigationStart();

[kmadhusu, 2015/03/16 21:35:30]

style nit: Can you rewrite this line as follows:
uint64 start =
    1000 *
(render_view()->GetMainRenderFrame()->GetWebFrame()->performance().navigationStart());

[fserb, 2015/03/16 21:45:49]

I can, but it doesn't fit in 80chars and the "git cl format" changes it back.

[kmadhusu, 2015/03/16 21:58:48]

You can break the line. I prefer to see 2 lines instead of 4 lines.

[fserb, 2015/03/16 22:05:32]

I changed it a bit, but if I run "git cl format" it reverts it back.

[kmadhusu, 2015/03/17 00:10:40]

I generally don't run "git cl format". 
Try this and see if it works:
uint64 start = 1000 * (render_view()->GetMainRenderFrame()->GetWebFrame()->
    performance().navigationStart());

+  uint64 now =
+      (base::TimeTicks::Now() - base::TimeTicks::UnixEpoch()).InMilliseconds();

[kmadhusu, 2015/03/16 21:35:30]

Is there any specific reason to use base::TimeTicks functions instead of
base::Time functions? 

[fserb, 2015/03/16 21:45:49]

Done.

+  DCHECK(now >= start);
+  uint64 delta = now - start;
   render_view()->Send(new ChromeViewHostMsg_LogEvent(
-      render_view()->GetRoutingID(), page_seq_no_, event));
+      render_view()->GetRoutingID(), page_seq_no_, event, delta));
 }
 
 void SearchBox::LogMostVisitedImpression(int position,
                                          const base::string16& provider) {
   render_view()->Send(new ChromeViewHostMsg_LogMostVisitedImpression(
       render_view()->GetRoutingID(), page_seq_no_, position, provider));
 }
 
 void SearchBox::LogMostVisitedNavigation(int position,
                                          const base::string16& provider) {
@@ skipping 312 matching lines @@
 
 void SearchBox::Reset() {
   query_.clear();
   embedded_search_request_params_ = EmbeddedSearchRequestParams();
   suggestion_ = InstantSuggestion();
   start_margin_ = 0;
   is_focused_ = false;
   is_key_capture_enabled_ = false;
   theme_info_ = ThemeBackgroundInfo();
 }