Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Issue 1006733002: Revert of Fix for menus blocking user activity detection. (Closed)

Created:
5 years, 9 months ago by Jun Mukai
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for menus blocking user activity detection. (patchset #6 id:100001 of https://codereview.chromium.org/998603003/) Reason for revert: Linux ChromiumOS Ozone bot fails Original issue's description: > Fix for menus blocking user activity detection. > > Menus used to block detecting user activity. The fix works by making the > UserActivityDetector a PlatformEventObserver rather than an > EventHandler. > > BUG=462735 > TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.* > > Committed: https://crrev.com/c655cc2a17c6c7fd113346bedc8433488c4b6dbe > Cr-Commit-Position: refs/heads/master@{#320400} TBR=sadrul@chromium.org,oshima@chromium.org,jamescook@chromium.org,afakhry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462735 Committed: https://crrev.com/4f634eb8e64c960b45fa30e7ea53da49951eec3b Cr-Commit-Position: refs/heads/master@{#320424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -78 lines) Patch
M ash/shell.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.h View 2 chunks +8 lines, -11 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 3 chunks +25 lines, -36 lines 0 comments Download
M ui/base/user_activity/user_activity_detector_unittest.cc View 14 chunks +13 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jun Mukai
Created Revert of Fix for menus blocking user activity detection.
5 years, 9 months ago (2015-03-13 01:48:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006733002/1
5 years, 9 months ago (2015-03-13 01:48:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 01:49:35 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 01:50:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f634eb8e64c960b45fa30e7ea53da49951eec3b
Cr-Commit-Position: refs/heads/master@{#320424}

Powered by Google App Engine
This is Rietveld 408576698