Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006723003: Fix template angle bracket syntax in dom (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromiumbugtracker_adobe.com, dglazkov+blink, dstockwell, eae+blinkwatch, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, sof, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in dom In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -120 lines) Patch
M Source/core/dom/CSSSelectorWatch.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildListMutationScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CrossThreadTask.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollector.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollector.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Fullscreen.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MainThreadTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/MutationObserverRegistration.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/MutationObserverRegistration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeListsNodeData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptedAnimationController.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/SelectorQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/StaticNodeList.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TouchList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/WeakNodeMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL. I can split the patch in half if you prefer! After this one there ...
5 years, 9 months ago (2015-03-14 00:28:18 UTC) #2
pdr.
lgtm
5 years, 9 months ago (2015-03-14 03:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006723003/1
5 years, 9 months ago (2015-03-14 03:25:39 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 05:10:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191877

Powered by Google App Engine
This is Rietveld 408576698