Postpone setting up file handler's file permissions if handler is running lazy background page.

chrome/browser/chromeos/extensions/file_browser_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_private_api.h"
 
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 558 matching lines @@
     task->SetString("iconUrl", icon.spec());
     result_list->Append(task);
   }
 
   // TODO(zelidrag, serya): Add intent content tasks to result_list once we
   // implement that API.
   SendResponse(true);
   return true;
 }
 
 class ExecuteTasksFileBrowserFunction::Executor: public FileTaskExecutor {

[Matt Perry, 2012/04/13 18:45:17]

space before last :

  public:
   Executor(Profile* profile,
            const GURL& source_url,
            const std::string& extension_id,
            const std::string& action_id,
            ExecuteTasksFileBrowserFunction* function)
     : FileTaskExecutor(profile, source_url, extension_id, action_id),
       function_(function)
   {}
 
  protected:
   // FileTaskExecutor overrides.
   virtual Browser* browser() { return function_->GetCurrentBrowser(); }
-  virtual void Done(bool success) { function_->SendResponse(success); }
+  virtual void Done(bool success) { function_->OnTaskExecuted(success); }
 
  private:
   scoped_refptr<ExecuteTasksFileBrowserFunction> function_;
 };
 
 ExecuteTasksFileBrowserFunction::ExecuteTasksFileBrowserFunction() {}
 
 ExecuteTasksFileBrowserFunction::~ExecuteTasksFileBrowserFunction() {}
 
 bool ExecuteTasksFileBrowserFunction::RunImpl() {
@@ skipping 24 matching lines @@
   std::vector<GURL> file_urls;
   for (size_t i = 0; i < files_list->GetSize(); i++) {
     std::string origin_file_url;
     if (!files_list->GetString(i, &origin_file_url)) {
       error_ = kInvalidFileUrl;
       return false;
     }
     file_urls.push_back(GURL(origin_file_url));
   }
 
-  scoped_refptr<Executor> executor =
-      new Executor(profile(), source_url(), extension_id, action_id, this);
-  if (!executor->Execute(file_urls))
+  executor_ = new Executor(profile(), source_url(), extension_id, action_id,
+                           this);
+
+  if (!executor_->Execute(file_urls)) {
+    // Executor has our reference, so we have to unref it if we don't want to
+    // leak.
+    executor_ = NULL;
     return false;
+  }
 
   result_.reset(new base::FundamentalValue(true));
   return true;
 }
 
+void ExecuteTasksFileBrowserFunction::OnTaskExecuted(bool success) {
+  SendResponse(success);
+  // Executor has our reference, so we have to unref it if we don't want to
+  // leak.
+  executor_ = NULL;
+}
+
 FileBrowserFunction::FileBrowserFunction() {
 }
 
 FileBrowserFunction::~FileBrowserFunction() {
 }
 
 int32 FileBrowserFunction::GetTabId() const {
   if (!dispatcher()) {
     LOG(WARNING) << "No dispatcher";
     return 0;
@@ skipping 1315 matching lines @@
   if (value->GetBoolean("cellularDisabled", &tmp)) {
     service->SetBoolean(prefs::kDisableGDataOverCellular, tmp);
   }
 
   if (value->GetBoolean("hostedFilesDisabled", &tmp)) {
     service->SetBoolean(prefs::kDisableGDataHostedFiles, tmp);
   }
 
   return true;
 }