Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1006693002: Add NavigationEntryImpl::TreeNode for tracking FrameNavigationEntries. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add NavigationEntryImpl::TreeNode for tracking FrameNavigationEntries. We still only track the main frame and do not share FNEs across NavigationEntries, but this new TreeNode class will make it possible to track them for subtrees and share them across entries of a tab. BUG=236848 TEST=Existing Navigation{Controller,Entry} tests pass. Committed: https://crrev.com/5005433dbcebaa2c649f60dea92f05f2ebabf1d0 Cr-Commit-Position: refs/heads/master@{#320730}

Patch Set 1 : Initial patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -23 lines) Patch
M content/browser/frame_host/frame_navigation_entry.h View 3 chunks +19 lines, -9 lines 1 comment Download
M content/browser/frame_host/frame_navigation_entry.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +25 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 6 chunks +27 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Charlie Reis
Next step: Add the tree structure and make FNE refcounted. This will let us start ...
5 years, 9 months ago (2015-03-12 23:29:55 UTC) #3
Charlie Reis
And... I have some tests to debug. No rush on the review-- I'll let you ...
5 years, 9 months ago (2015-03-12 23:42:48 UTC) #4
Charlie Reis
And, nevermind. The failures were unrelated and went green with another round of try jobs. ...
5 years, 9 months ago (2015-03-13 17:58:13 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-13 21:08:03 UTC) #6
Charlie Reis
Great, thanks. I'll land it on Monday just to be safe, which should give the ...
5 years, 9 months ago (2015-03-13 21:26:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006693002/20001
5 years, 9 months ago (2015-03-16 14:34:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-16 15:52:45 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:53:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5005433dbcebaa2c649f60dea92f05f2ebabf1d0
Cr-Commit-Position: refs/heads/master@{#320730}

Powered by Google App Engine
This is Rietveld 408576698