Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: mojo/public/cpp/bindings/binding.h

Issue 1006653002: Closes the pipe when a Binding is destroyed. This was always the intended (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/binding.h
diff --git a/mojo/public/cpp/bindings/binding.h b/mojo/public/cpp/bindings/binding.h
index f178431c3f9d5731d669c390c468946cb2bf71a6..feb2a82518c435bd0c0935889a633f416cb081c1 100644
--- a/mojo/public/cpp/bindings/binding.h
+++ b/mojo/public/cpp/bindings/binding.h
@@ -101,6 +101,7 @@ class Binding : public ErrorHandler {
// implementation unbound.
~Binding() override {
if (internal_router_) {
+ internal_router_->CloseMessagePipe();
jamesr 2015/03/12 21:01:10 instead of these two calls could you just call Clo
DestroyRouter();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698