net/socket/transport_client_socket_pool.h - Issue 1006643002: Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/transport_client_socket_pool.h

Issue 1006643002: Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a few more tests Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_transaction.cc ('K') | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/socket/transport_client_socket_pool.cc » ('j') | net/socket/transport_client_socket_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/transport_client_socket_pool.h

diff --git a/net/socket/transport_client_socket_pool.h b/net/socket/transport_client_socket_pool.h

index 48ddd1334fab5974b651eb04bc293ac885f9bd49..de57d18aa80f803c24ddce436fce8d11035b306f 100644

--- a/net/socket/transport_client_socket_pool.h

+++ b/net/socket/transport_client_socket_pool.h

@@ -167,6 +167,7 @@ class NET_EXPORT_PRIVATE TransportConnectJob : public ConnectJob {

// ConnectJob methods.

LoadState GetLoadState() const override;

+ void GetAdditionalErrorState(ClientSocketHandle* handle) override;

// Rolls |addrlist| forward until the first IPv4 address, if any.

// WARNING: this method should only be used to implement the prefer-IPv4 hack.

@@ -207,6 +208,9 @@ class NET_EXPORT_PRIVATE TransportConnectJob : public ConnectJob {

// Track the interval between this connect and previous connect.

ConnectInterval interval_between_connects_;

+ int resolve_result_;

+ int connect_result_;

DISALLOW_COPY_AND_ASSIGN(TransportConnectJob);

};