net/http/http_stream_factory.h - Issue 1006643002: Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory.h

Issue 1006643002: Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_transaction.cc ('K') | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_factory_impl_job.h » ('j') | net/socket/client_socket_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory.h

diff --git a/net/http/http_stream_factory.h b/net/http/http_stream_factory.h

index e6712623fb0428d3f36a213dcaa31870b1c07379..4ec7d851f05d893dda1dbc4d9d10ff2ea097fa13 100644

--- a/net/http/http_stream_factory.h

+++ b/net/http/http_stream_factory.h

@@ -16,6 +16,7 @@

#include "net/base/net_export.h"

#include "net/base/request_priority.h"

#include "net/http/http_server_properties.h"

+#include "net/socket/client_socket_handle.h"

Randy Smith (Not in Mondays) 2015/04/10 21:15:03 nit: Why is this added? None of the other additio

Deprecated (see juliatuttle) 2015/04/14 19:14:45 Leftover from when ConnectionAttempts was a member

Randy Smith (Not in Mondays) 2015/04/15 20:19:07 Hmmm. Why doesn't that mean it should be removed?

// This file can be included from net/http even though

// it is in net/websockets because it doesn't

// introduce any link dependency to net/websockets.

@@ -170,6 +171,9 @@ class NET_EXPORT_PRIVATE HttpStreamRequest {

// Returns true if this stream is being fetched over SPDY.

virtual bool using_spdy() const = 0;

+ // Returns socket-layer connection attempts made for this stream request.

+ virtual const ConnectionAttempts& connection_attempts() const = 0;

};

// The HttpStreamFactory defines an interface for creating usable HttpStreams.

« net/http/http_network_transaction.cc ('K') | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_stream_factory_impl_job.h » ('j') | net/socket/client_socket_handle.h » ('J')