Plumb connection attempts from (non-proxy) ConnectJobs to HttpNetworkTransaction.

net/http/http_network_transaction.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_TRANSACTION_H_
 #define NET_HTTP_HTTP_NETWORK_TRANSACTION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 80 matching lines @@
   void OnNeedsProxyAuth(const HttpResponseInfo& response_info,
                         const SSLConfig& used_ssl_config,
                         const ProxyInfo& used_proxy_info,
                         HttpAuthController* auth_controller) override;
   void OnNeedsClientAuth(const SSLConfig& used_ssl_config,
                          SSLCertRequestInfo* cert_info) override;
   void OnHttpsProxyTunnelResponse(const HttpResponseInfo& response_info,
                                   const SSLConfig& used_ssl_config,
                                   const ProxyInfo& used_proxy_info,
                                   HttpStream* stream) override;
 

[Ryan Hamilton, 2015/03/24 19:20:19]

Probably should have a comment here. The other methods do not because they're
all overrides.

+  const ClientSocketHandle::ConnectionAttempts& connection_attempts() const;

[Ryan Hamilton, 2015/03/24 19:20:19]

This makes me wonder if ConnectionAttempts should be defined in some other .h
file since it's getting exposed up the stack. It doesn't seem like consumers
should care about ClientSocketHandles. maybe just
net/socket/connection_attempts.h ?

[Deprecated (see juliatuttle), 2015/04/08 19:17:19]

Done.

+
  private:
   friend class HttpNetworkTransactionSSLTest;
 
   FRIEND_TEST_ALL_PREFIXES(HttpNetworkTransactionTest,
                            ResetStateForRestart);
   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionTest,
                            WindowUpdateReceived);
   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionTest,
                            WindowUpdateSent);
   FRIEND_TEST_ALL_PREFIXES(SpdyNetworkTransactionTest,
@@ skipping 138 matching lines @@
   GURL AuthURL(HttpAuth::Target target) const;
 
   // Returns true if this transaction is for a WebSocket handshake
   bool ForWebSocketHandshake() const;
 
   // Debug helper.
   static std::string DescribeState(State state);
 
   void SetStream(HttpStream* stream);
 
+  void CopyConnectionAttempts();
+
   scoped_refptr<HttpAuthController>
       auth_controllers_[HttpAuth::AUTH_NUM_TARGETS];
 
   // Whether this transaction is waiting for proxy auth, server auth, or is
   // not waiting for any auth at all. |pending_auth_target_| is read and
   // cleared by RestartWithAuth().
   HttpAuth::Target pending_auth_target_;
 
   CompletionCallback io_callback_;
   CompletionCallback callback_;
@@ skipping 50 matching lines @@
   bool establishing_tunnel_;
 
   // The helper object to use to create WebSocketHandshakeStreamBase
   // objects. Only relevant when establishing a WebSocket connection.
   WebSocketHandshakeStreamBase::CreateHelper*
       websocket_handshake_stream_base_create_helper_;
 
   BeforeNetworkStartCallback before_network_start_callback_;
   BeforeProxyHeadersSentCallback before_proxy_headers_sent_callback_;
 
+  ClientSocketHandle::ConnectionAttempts connection_attempts_;
+
   DISALLOW_COPY_AND_ASSIGN(HttpNetworkTransaction);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_TRANSACTION_H_