Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/android_platform/README.chromium

Issue 1006603002: Fix stack tool for library in apk crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_platform/README.chromium
diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium
index 461efa3add809c9107e9a765af11e4fc0b8bd6b1..7068df46768804db9fd2287ebb3f0eecc346ac14 100644
--- a/third_party/android_platform/README.chromium
+++ b/third_party/android_platform/README.chromium
@@ -17,10 +17,16 @@ jar is built by invoking make on the android_system_stubs target.
Local Modifications:
Only picked the few scripts needed by chrome.
+
+The scripts have been modified to better suit Chromium development. Changes
+include, but are not limited to, the following:
+Added memoization of addr2line and objdump.
+Added option to change the amount of symbolization done.
Updated output directories to use environment variable.
When calling addr2line, check the symbol is a file (and not a directory).
Added support for parsing LOG(FATAL) and DCHECK errors and their
stack traces, as emitted by src/base/debug/stack_trace_android.cc
Added support for finding symbols when library is loaded directly from the APK.
Changed the toolchain to remove references to 4.6 toolchains.
-Added support for arch=x64 as an alias to arch=x86_64
+Added support for arch=x64 as an alias to arch=x86_64
+Added debug logging and --verbose parameter.

Powered by Google App Engine
This is Rietveld 408576698