Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1006603002: Fix stack tool for library in apk crashes (Closed)

Created:
5 years, 9 months ago by cjhopman
Modified:
5 years, 8 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix stack tool for library in apk crashes This patches the python zipfile implementation to ignore struct unpack errors in _decodeExtra. See http://bugs.python.org/issue14315 Also adds a --verbose option that enables a bunch of logging to help diagnose failed symbolization. Fixes stack tool for gn builds where libs are put in the top-level output directory. Committed: https://crrev.com/09d7b09acb5a91d53f9fc48a44549e7964213ef8 Cr-Commit-Position: refs/heads/master@{#325573}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -20 lines) Patch
M third_party/android_platform/README.chromium View 1 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/stack View 5 chunks +10 lines, -3 lines 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 1 9 chunks +43 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cjhopman
rmcilroy: *
5 years, 9 months ago (2015-03-12 18:43:06 UTC) #2
rmcilroy
A couple of comments, but lgtm. Thanks for doing these fixes! https://codereview.chromium.org/1006603002/diff/1/third_party/android_platform/development/scripts/stack File third_party/android_platform/development/scripts/stack (right): ...
5 years, 9 months ago (2015-03-12 21:50:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006603002/20001
5 years, 8 months ago (2015-04-17 00:28:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 00:56:48 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 00:57:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09d7b09acb5a91d53f9fc48a44549e7964213ef8
Cr-Commit-Position: refs/heads/master@{#325573}

Powered by Google App Engine
This is Rietveld 408576698