src/codec/SkCodec_wbmp.h - Issue 1006583005: SkCodec: add wbmp class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/codec/SkCodec_wbmp.h

Issue 1006583005: SkCodec: add wbmp class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2015 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef SkCodec_wbmp_DEFINED

	9 #define SkCodec_wbmp_DEFINED

	10

	11 class SkCodec;

	12 class SkStream;

	13

	14 namespace SkWbmpCodec {
	msarett 2015/03/26 12:37:35 What is the effect of declaring a namespace? I'm What is the effect of declaring a namespace? I'm just curious how this works. Is this in place of declaring the class? scroggo 2015/03/26 14:37:57 Yes. It's mostly the same if all your methods are Show quoted text On 2015/03/26 12:37:35, msarett wrote: > What is the effect of declaring a namespace? I'm just curious how this works. > Is this in place of declaring the class? Yes. It's mostly the same if all your methods are static. I believe there's some internal disagreement on the Skia team as to the better way to do it. hal.canary 2015/03/26 17:10:53 I find that namespace makes it more clear that thi Show quoted text On 2015/03/26 14:37:57, scroggo wrote: > On 2015/03/26 12:37:35, msarett wrote: > > What is the effect of declaring a namespace? I'm just curious how this works. > > > Is this in place of declaring the class? > > Yes. It's mostly the same if all your methods are static. I believe there's some > internal disagreement on the Skia team as to the better way to do it. I find that namespace makes it more clear that this is not the data structure.
	15 bool IsWbmp(SkStream*);

	16 SkCodec* NewFromStream(SkStream*);

	17 };

	18

	19 #endif // SkCodec_wbmp_DEFINED

OLD	NEW

« dm/DMSrcSink.cpp ('K') | « src/codec/SkCodec.cpp ('k') | src/codec/SkCodec_wbmp.cpp » ('j') | src/codec/SkCodec_wbmp.cpp » ('J')