Chromium Code Reviews

Issue 1006583004: Fix host_arch detection for AIX and one new warning as error (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
MTBrandyberry, Sven Panne, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix host_arch detection for AIX and one new warning as error The value returned on AIX for platform.machine() is not the best value to map the architecture from. Use platform.system to determine if we are on AIX and if so set host_arch to ppc64 as AIX 6.1 (the earliest supported) only provides a 64 bit kernel AIX was reporting warning that offset may be used uninitialized modified: build/detect_v8_host_arch.py modified: build/standalone.gypi modified: src/hydrogen-bce.cc R=mbrandy@us.ibm.com, jkummerow@chromium.org BUG= Committed: https://crrev.com/2ec0f32abbf474fab6e618c0056765b483a66b2f Cr-Commit-Position: refs/heads/master@{#27463}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+10 lines, -2 lines)
M build/detect_v8_host_arch.py View 2 chunks +8 lines, -0 lines 0 comments
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments
M src/hydrogen-bce.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
michael_dawson
Fixes to get AIX building again.
5 years, 9 months ago (2015-03-25 20:54:16 UTC) #2
Sven Panne
Drive-by LGTM...
5 years, 9 months ago (2015-03-26 07:22:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006583004/1
5 years, 9 months ago (2015-03-26 07:22:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 08:06:46 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 08:07:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ec0f32abbf474fab6e618c0056765b483a66b2f
Cr-Commit-Position: refs/heads/master@{#27463}

Powered by Google App Engine