extensions/browser/api/printer_provider/printer_provider_api.cc - Issue 1006583003: Add title property to chrome.printerProvider pritn job

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 1006583003: Add title property to chrome.printerProvider pritn job (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_handler.h ('k') | extensions/browser/api/printer_provider/printer_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_api.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc

index f993f8114722bb035d72e12877c7aad31dcdd6f7..cf1fda6ed4e7fde4a6d74c021b97c39b830ad54b 100644

--- a/extensions/browser/api/printer_provider/printer_provider_api.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc

@@ -16,6 +16,7 @@

#include "base/memory/ref_counted_memory.h"

#include "base/scoped_observer.h"

#include "base/strings/string16.h"

+#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

#include "extensions/browser/api/printer_provider/printer_provider_print_job.h"

#include "extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h"

@@ -510,6 +511,7 @@ void PrinterProviderAPIImpl::DispatchPrintRequested(

}

print_job.content_type = job.content_type;

+ print_job.title = base::UTF16ToUTF8(job.job_title);

int request_id = pending_print_requests_[extension_id].Add(job, callback);

scoped_ptr<base::ListValue> internal_args(new base::ListValue);