Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

Issue 1006583002: Reset unreachable data reduction proxy message when data savings is toggled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Vector initialization. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
index dcec95e2c05d7171c386b3a59b0c5262dfe6b8ef..b13dc9494797a84f8785f3782fdba06f762ae4f6 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
@@ -80,6 +80,14 @@ class DataReductionProxyBypassStats
void OnConnectComplete(const net::HostPortPair& proxy_server,
int net_error);
+ // Unconditionally clears counts of successful requests and net errors when
+ // using the Data Reduction Proxy.
+ void ClearRequestCounts();
+
+ // Checks if the availability status of the Data Reduction Proxy has changed,
+ // and calls |unreachable_callback_| if so.
+ void NotifyUnavailabilityIfChanged();
+
private:
friend class DataReductionProxyBypassStatsTest;
FRIEND_TEST_ALL_PREFIXES(DataReductionProxyBypassStatsTest,
@@ -115,17 +123,6 @@ class DataReductionProxyBypassStats
void OnNetworkChanged(
net::NetworkChangeNotifier::ConnectionType type) override;
- // Clears request counts unconditionally.
- void ClearRequestCounts();
-
- // Checks if the availability status of the data reduction proxy has changed,
- // and notifies the UIThread via NotifyUnavailabilityOnUIThread if so. The
- // data reduction proxy is considered unavailable if and only if no requests
- // went through the proxy but some eligible requests were service by other
- // routes.
- void NotifyUnavailabilityIfChanged();
- void NotifyUnavailabilityOnUIThread(bool unavailable);
-
void RecordBypassedBytes(
DataReductionProxyBypassType bypass_type,
BypassedBytesType bypassed_bytes_type,
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698