chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc - Issue 1006553002: Add third-party VPN support to network details dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc

Issue 1006553002: Add third-party VPN support to network details dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_2_460428_add_ash_ui

Patch Set: Prepare for removal of GetManagedPropertiesResult() by tracking VPN providers and networks separate… Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('K') | « chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc

index ddb1ca25d8f880cbd9b5e25039e1b0a7aec82bda..62d33f2aa5def618df03e2a72442a0b353d17323 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler_strings.cc

@@ -27,6 +27,8 @@ StringResource kStringResources[] = {

{"wimaxTitle", IDS_OPTIONS_SETTINGS_SECTION_TITLE_WIMAX_NETWORK},

{"cellularTitle", IDS_OPTIONS_SETTINGS_SECTION_TITLE_CELLULAR_NETWORK},

{"vpnTitle", IDS_OPTIONS_SETTINGS_SECTION_TITLE_PRIVATE_NETWORK},

+ {"vpnNameTemplate",

+ IDS_OPTIONS_SETTINGS_SECTION_THIRD_PARTY_VPN_NAME_TEMPLATE},

{"joinOtherNetwork", IDS_OPTIONS_SETTINGS_NETWORK_OTHER},

{"networkDisabled", IDS_OPTIONS_SETTINGS_NETWORK_DISABLED},

{"turnOffWifi", IDS_OPTIONS_SETTINGS_NETWORK_DISABLE_WIFI},

@@ -136,6 +138,8 @@ StringResource kStringResources[] = {

IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_SERVER_HOSTNAME},

{"inetProviderType",

IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_PROVIDER_TYPE},

+ {"inetProviderName",

+ IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_PROVIDER_NAME},

{"inetUsername", IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_VPN_USERNAME},

// Cellular Tab.