chrome/browser/resources/options/chromeos/network_list.js - Issue 1006553002: Add third-party VPN support to network details dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/network_list.js

Issue 1006553002: Add third-party VPN support to network details dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_2_460428_add_ash_ui

Patch Set: Addressed comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/chromeos/internet_detail.js ('k') | chrome/browser/resources/options/chromeos/vpn_providers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/network_list.js

diff --git a/chrome/browser/resources/options/chromeos/network_list.js b/chrome/browser/resources/options/chromeos/network_list.js

index 9f77451e8594edf2c502550c63751f0a0d678167..09e1a6a10b6bba945a352ae0de0291353c0ddc99 100644

--- a/chrome/browser/resources/options/chromeos/network_list.js

+++ b/chrome/browser/resources/options/chromeos/network_list.js

@@ -133,6 +133,8 @@ cr.define('options.network', function() {

function getNetworkName(data) {

if (data.Type == 'Ethernet')

return loadTimeData.getString('ethernetName');

+ if (data.Type == 'VPN')

+ return options.VPNProviders.formatNetworkName(new cr.onc.OncData(data));

return data.Name;

}