Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4749)

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.html

Issue 1006553002: Add third-party VPN support to network details dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@f_2_460428_add_ash_ui
Patch Set: Addressed comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/internet_detail.html
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.html b/chrome/browser/resources/options/chromeos/internet_detail.html
index 313dddb27fac6520f10c3c004f585fb9674c4a5b..09e2567269978d64f5818f0aa5a41423eddf55c2 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.html
+++ b/chrome/browser/resources/options/chromeos/internet_detail.html
@@ -203,7 +203,7 @@
<div id="vpn-tab" class="subpages-tab-contents vpn-details">
<section>
<table class="option-control-table">
- <tr class="auto-connect-network">
+ <tr class="auto-connect-network built-in-vpn-provider-only">
<td>
<div class="checkbox controlled-setting-with-label">
<label>
@@ -222,7 +222,7 @@
<td class="option-name" i18n-content="inetServiceName"></td>
<td id="inet-service-name" class="option-value"></td>
</tr>
- <tr>
+ <tr class="built-in-vpn-provider-only">
<td class="option-name" i18n-content="inetServerHostname"></td>
<td>
<input class="option-value" id="inet-server-hostname"></input>
@@ -235,7 +235,11 @@
<td class="option-name" i18n-content="inetProviderType"></td>
<td id="inet-provider-type" class="option-value"></td>
</tr>
- <tr>
+ <tr class="third-party-vpn-provider-only">
+ <td class="option-name" i18n-content="inetProviderName"></td>
+ <td id="inet-provider-name" class="option-value"></td>
+ </tr>
+ <tr class="built-in-vpn-provider-only">
<td class="option-name" i18n-content="inetUsername"></td>
<td id="inet-username" class="option-value"></td>
</tr>

Powered by Google App Engine
This is Rietveld 408576698