Issue 1006533002: Factor a Scrollable base class out of FixedHeightScrollable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1006533002: Factor a Scrollable base class out of FixedHeightScrollable (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Factor a Scrollable base class out of FixedHeightScrollable This class encapsulates the scrolling behavior but not the mechanism for building the visual components. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cff0ebdf2ba13795b50309b536f958a0bf5ef079

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -80 lines)			Patch
	M	sky/framework/components/fixed_height_scrollable.dart	View		4 chunks	+8 lines, -80 lines	0 comments	Download
	A	sky/framework/components/scrollable.dart	View		1 chunk	+88 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-12 17:10:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cff0ebdf2ba13795b50309b536f958a0bf5ef079 (presubmit successful).