Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 1006513002: MIPS: [turbofan] Introduce optional Float64Min and Float64Max machine operators. (Closed)

Created:
5 years, 9 months ago by balazs.kilvady
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Introduce optional Float64Min and Float64Max machine operators. Port 99f8d57f3c5d967bc3b10356b22d7ec7be55e89f Original commit message: Basically recognize certain x < y ? x : y constructs and turn that into Float64Min/Float64Max operations, if the target machine supports that. On x86 we lower to (v)minsd/(v)maxsd. BUG= Committed: https://crrev.com/323ec9e8bda05bdc0a0f7eb55e910f7c28b2e1bc Cr-Commit-Position: refs/heads/master@{#27168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 9 months ago (2015-03-12 16:06:18 UTC) #2
paul.l...
lgtm
5 years, 9 months ago (2015-03-12 16:21:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006513002/1
5 years, 9 months ago (2015-03-12 16:23:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 16:43:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:43:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/323ec9e8bda05bdc0a0f7eb55e910f7c28b2e1bc
Cr-Commit-Position: refs/heads/master@{#27168}

Powered by Google App Engine
This is Rietveld 408576698