Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1006493002: [svg2] Exclude <pattern> from having x and y presentation attributes (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[svg2] <pattern> doesn't have x and y presentation attributes BUG=400725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191837

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M LayoutTests/svg/zoom/xy-getcomputedstyle.html View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Erik Dahlström (inactive)
Split out from https://codereview.chromium.org/963733002/.
5 years, 9 months ago (2015-03-12 16:15:10 UTC) #2
fs
LGTM w/ nit https://codereview.chromium.org/1006493002/diff/1/Source/core/svg/SVGPatternElement.cpp File Source/core/svg/SVGPatternElement.cpp (right): https://codereview.chromium.org/1006493002/diff/1/Source/core/svg/SVGPatternElement.cpp#newcode109 Source/core/svg/SVGPatternElement.cpp:109: updateRelativeLengthsInformation(); Nit: This block is now ...
5 years, 9 months ago (2015-03-12 16:31:39 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/1006493002/diff/1/Source/core/svg/SVGPatternElement.cpp File Source/core/svg/SVGPatternElement.cpp (right): https://codereview.chromium.org/1006493002/diff/1/Source/core/svg/SVGPatternElement.cpp#newcode109 Source/core/svg/SVGPatternElement.cpp:109: updateRelativeLengthsInformation(); On 2015/03/12 16:31:39, fs wrote: > Nit: This ...
5 years, 9 months ago (2015-03-13 09:04:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006493002/20001
5 years, 9 months ago (2015-03-13 09:04:36 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 12:01:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191837

Powered by Google App Engine
This is Rietveld 408576698