extensions/common/permissions/permissions_data.h - Issue 1006453002: Extensions: Prepare switch to new permission message system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 1006453002: Extensions: Prepare switch to new permission message system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/permissions/permission_message_provider.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/permissions_data.h

diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h

index 9a24fbf05d28d6288902bf7d2eb0dd686d5962a4..ab7ea526c499e11f7a49de77b544de852583a35c 100644

--- a/extensions/common/permissions/permissions_data.h

+++ b/extensions/common/permissions/permissions_data.h

@@ -131,10 +131,10 @@ class PermissionsData {

// network, etc.)

bool HasEffectiveAccessToAllHosts() const;

- // Returns the full list of permission messages that should display at

- // install time.

- // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().

- PermissionMessages GetPermissionMessages() const;

+ // Returns the full list of legacy permission message IDs.

+ // Deprecated. You DO NOT want to call this!

+ // TODO(treib): Remove once we've switched to the new system.

+ PermissionMessageIDs GetLegacyPermissionMessageIDs() const;

// Returns the full list of permission messages that should display at install

// time as strings.

« no previous file with comments | « extensions/common/permissions/permission_message_provider.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »