chrome/browser/extensions/api/permissions/permissions_api.cc - Issue 1006453002: Extensions: Prepare switch to new permission message system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 1006453002: Extensions: Prepare switch to new permission message system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/ephemeral_app_launcher.cc ('k') | chrome/browser/extensions/extension_disabled_ui.cc » ('j') | chrome/common/extensions/permissions/chrome_permission_message_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api.cc b/chrome/browser/extensions/api/permissions/permissions_api.cc

index d7346ec85204b6070dbbcefde0d3eb1e4a730501..4618d98a5167296ce250a50a5eaf53af094873df 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api.cc

@@ -218,10 +218,11 @@ bool PermissionsRequestFunction::RunAsync() {

// We don't need to show the prompt if there are no new warnings, or if

// we're skipping the confirmation UI. All extension types but INTERNAL

// are allowed to silently increase their permission level.

- bool has_no_warnings = PermissionMessageProvider::Get()

- ->GetWarningMessages(requested_permissions_.get(),

- extension()->GetType())

- .empty();

+ bool has_no_warnings =

+ PermissionMessageProvider::Get()

+ ->GetLegacyWarningMessages(requested_permissions_.get(),

+ extension()->GetType())

+ .empty();

if (auto_confirm_for_tests == PROCEED || has_no_warnings ||

extension_->location() == Manifest::COMPONENT) {

InstallUIProceed();