Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1006423007: Fix timeouts in overflow-scroll-animates.html with threaded compositing. (Closed)

Created:
5 years, 9 months ago by skobes
Modified:
5 years, 9 months ago
Reviewers:
ajuma
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix timeout of overflow-scroll-animates.html in virtual/threaded. When threaded compositing is enabled, the effect of adding or removing a scroll listener does not happen until the next frame. To compensate for this, the test now waits before triggering input with eventSender. BUG=458420, 575 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-animates.html View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
skobes
5 years, 9 months ago (2015-03-18 02:41:31 UTC) #2
ajuma
lgtm, but please add a sentence or two to the description, explaining how this fixes ...
5 years, 9 months ago (2015-03-18 13:23:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006423007/1
5 years, 9 months ago (2015-03-18 18:16:09 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 18:20:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192111

Powered by Google App Engine
This is Rietveld 408576698