Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1006403002: [Ozone-Drm] Do not try to take ref_ptr from destructor (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Drm] Do not try to take ref_ptr from destructor Can't post a task with a ref-counted instance of the watcher from the destructor. BUG=467170 Committed: https://crrev.com/8c08f77eae4c223b72d0a404b9139b179ec53e24 Cr-Commit-Position: refs/heads/master@{#320739}

Patch Set 1 #

Patch Set 2 : Wait #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dnicoara
PTAL
5 years, 9 months ago (2015-03-16 15:15:29 UTC) #2
alexst (slow to review)
lgtm
5 years, 9 months ago (2015-03-16 15:22:13 UTC) #3
dnicoara
Updated to actually wait on the WaitableEvent
5 years, 9 months ago (2015-03-16 15:44:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006403002/20001
5 years, 9 months ago (2015-03-16 16:58:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 17:05:14 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 17:05:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c08f77eae4c223b72d0a404b9139b179ec53e24
Cr-Commit-Position: refs/heads/master@{#320739}

Powered by Google App Engine
This is Rietveld 408576698