Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1006383004: Adding an easy(ier) to use tool to start legion-based tests. This tool handles all of the isolate a… (Closed)

Created:
5 years, 9 months ago by Mike Meade
Modified:
5 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding an easy(ier) to use tool to start legion-based tests. This tool handles all of the isolate archives, building the test controller command line, and running the test controller. BUG=467618 Committed: https://crrev.com/3f2796443ad61ce8e4817f34586942af4f77ad5e Cr-Commit-Position: refs/heads/master@{#320754}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding a trailing comma per feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
A testing/legion/tools/legion.py View 1 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mike Meade
5 years, 9 months ago (2015-03-16 17:11:32 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/1006383004/diff/1/testing/legion/tools/legion.py File testing/legion/tools/legion.py (right): https://codereview.chromium.org/1006383004/diff/1/testing/legion/tools/legion.py#newcode122 testing/legion/tools/legion.py:122: args.controller_isolated add trailing comma
5 years, 9 months ago (2015-03-16 17:49:43 UTC) #3
Mike Meade
https://codereview.chromium.org/1006383004/diff/1/testing/legion/tools/legion.py File testing/legion/tools/legion.py (right): https://codereview.chromium.org/1006383004/diff/1/testing/legion/tools/legion.py#newcode122 testing/legion/tools/legion.py:122: args.controller_isolated On 2015/03/16 17:49:42, M-A Ruel wrote: > add ...
5 years, 9 months ago (2015-03-16 18:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006383004/20001
5 years, 9 months ago (2015-03-16 18:00:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 18:23:54 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 18:24:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f2796443ad61ce8e4817f34586942af4f77ad5e
Cr-Commit-Position: refs/heads/master@{#320754}

Powered by Google App Engine
This is Rietveld 408576698