Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1006373006: New SRT prompt strings. (Closed)

Created:
5 years, 9 months ago by robertshield%chromium.org
Modified:
5 years, 9 months ago
Reviewers:
MAD, robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New SRT prompt strings. BUG=NONE TEST=NONE NOTRY=true Committed: https://crrev.com/e778ea03683b0d76c968c5d662d28dbddb6b2a1d Cr-Commit-Position: refs/heads/master@{#322242}

Patch Set 1 #

Patch Set 2 : Remove repeated title #

Patch Set 3 : Remove the term downloading #

Patch Set 4 : Move resource to generated resources.grd" #

Patch Set 5 : rebase #

Patch Set 6 : one more try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
robertshield
5 years, 9 months ago (2015-03-24 03:24:39 UTC) #2
MAD
lgtm
5 years, 9 months ago (2015-03-24 12:04:58 UTC) #3
MAD
I take that back... I just realized we made a mistake and included the title ...
5 years, 9 months ago (2015-03-24 12:20:05 UTC) #4
robertshield
Thanks, PTAL.
5 years, 9 months ago (2015-03-24 16:39:23 UTC) #5
MAD
Still, LGTM, unless we want to wait for the change that has been discussed over ...
5 years, 9 months ago (2015-03-24 16:41:41 UTC) #6
MAD
Yep, purrrrrfect! :-P LGTM... again :-) BYE MAD
5 years, 9 months ago (2015-03-25 21:19:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006373006/80001
5 years, 9 months ago (2015-03-25 21:22:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, no build URL) android_chromium_gn_compile_dbg on ...
5 years, 9 months ago (2015-03-25 21:30:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006373006/100001
5 years, 9 months ago (2015-03-25 21:52:47 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-25 21:54:25 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 21:55:09 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e778ea03683b0d76c968c5d662d28dbddb6b2a1d
Cr-Commit-Position: refs/heads/master@{#322242}

Powered by Google App Engine
This is Rietveld 408576698