Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1006373003: Generate externs automatically from json/idl files (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate externs automatically from json/idl files Continued from https://codereview.chromium.org/511943003/. BUG=469920 Committed: https://crrev.com/8c3a458ed264db8970f72c71be0e32a2a071ec30 Cr-Commit-Position: refs/heads/master@{#322016}

Patch Set 1 : Patch from https://codereview.chromium.org/511943003 #

Patch Set 2 : Edits #

Total comments: 18

Patch Set 3 : #

Patch Set 4 : #

Total comments: 6

Patch Set 5 : Tyler's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -1 line) Patch
M tools/json_schema_compiler/compiler.py View 3 chunks +6 lines, -1 line 0 comments Download
A tools/json_schema_compiler/js_externs_generator.py View 1 2 3 4 1 chunk +232 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/model.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Devlin
Hey Tyler and Dan - since Vitaly's not working on chrome much now, I figured ...
5 years, 9 months ago (2015-03-19 18:47:47 UTC) #2
Dan Beam
btw, tbreisacher@'s ooo https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/create_externs.sh File tools/json_schema_compiler/create_externs.sh (right): https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/create_externs.sh#newcode1 tools/json_schema_compiler/create_externs.sh:1: #!/bin/bash :_( https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): ...
5 years, 9 months ago (2015-03-19 19:15:03 UTC) #3
Devlin
Sorry for the roughness; thought you and Tyler had already looked over the original, and ...
5 years, 9 months ago (2015-03-19 20:59:57 UTC) #4
Dan Beam
lgtm https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/js_externs_generator.py#newcode42 tools/json_schema_compiler/js_externs_generator.py:42: .Append()) On 2015/03/19 20:59:57, Devlin wrote: > On ...
5 years, 9 months ago (2015-03-23 21:58:42 UTC) #5
Devlin
https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1006373003/diff/20001/tools/json_schema_compiler/js_externs_generator.py#newcode42 tools/json_schema_compiler/js_externs_generator.py:42: .Append()) On 2015/03/23 21:58:42, Dan Beam wrote: > On ...
5 years, 9 months ago (2015-03-23 23:20:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006373003/60001
5 years, 9 months ago (2015-03-23 23:21:17 UTC) #9
Dan Beam
still lgtm https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py#newcode104 tools/json_schema_compiler/js_externs_generator.py:104: if not properties: return Code() fwiw, 1-line ...
5 years, 9 months ago (2015-03-23 23:22:56 UTC) #10
Tyler Breisacher (Chromium)
I haven't looked at this in too much detail, this is just a couple things ...
5 years, 9 months ago (2015-03-23 23:33:52 UTC) #11
Devlin
https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py#newcode70 tools/json_schema_compiler/js_externs_generator.py:70: var += ';' On 2015/03/23 23:33:52, Tyler Breisacher (Chromium) ...
5 years, 9 months ago (2015-03-23 23:41:41 UTC) #13
Devlin
https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py File tools/json_schema_compiler/js_externs_generator.py (right): https://codereview.chromium.org/1006373003/diff/60001/tools/json_schema_compiler/js_externs_generator.py#newcode114 tools/json_schema_compiler/js_externs_generator.py:114: # remove last trailing comma On 2015/03/23 23:33:52, Tyler ...
5 years, 9 months ago (2015-03-23 23:41:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006373003/80001
5 years, 9 months ago (2015-03-24 15:53:06 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-24 17:07:39 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 17:08:25 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8c3a458ed264db8970f72c71be0e32a2a071ec30
Cr-Commit-Position: refs/heads/master@{#322016}

Powered by Google App Engine
This is Rietveld 408576698