Issue 1006363004: Introduce sky/framework/theme/typography.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1006363004: Introduce sky/framework/theme/typography.dart (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Introduce sky/framework/theme/typography.dart This CL adds typography information to the Sky theme. The values are from the Material Design spec. I've also applied these values to the stocks app and the various components. We're not geting precisely the right typography in some cases because of https://github.com/domokit/mojo/issues/65. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c9ce964bec1a210479577e89642a267777b88864

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -28 lines)			Patch
M	sky/examples/stocks-fn/stockrow.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	sky/examples/stocks-fn/stocksapp.dart	View		4 chunks	+18 lines, -16 lines	0 comments	Download
M	sky/framework/components/action_bar.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/drawer_header.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/framework/components/floating_action_button.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/framework/components/menu_item.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
A	sky/framework/theme/typography.dart	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-17 03:53:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c9ce964bec1a210479577e89642a267777b88864 (presubmit successful).