Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: Source/bindings/tests/results/modules/UnionTypesModules.cpp

Issue 1006323002: [bindings] Pass v8::Local<v8::Value> by value in NativeValueTraits<T>::nativeValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/UnionTypesModules.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/modules/UnionTypesModules.cpp
diff --git a/Source/bindings/tests/results/modules/UnionTypesModules.cpp b/Source/bindings/tests/results/modules/UnionTypesModules.cpp
index 75ba666b57eb93700a0133cc800ea1bc90c16824..9ca446f6361cef9b45a4d884a095d85fe7b289e0 100644
--- a/Source/bindings/tests/results/modules/UnionTypesModules.cpp
+++ b/Source/bindings/tests/results/modules/UnionTypesModules.cpp
@@ -90,7 +90,7 @@ v8::Local<v8::Value> toV8(const BooleanOrString& impl, v8::Local<v8::Object> cre
return v8::Local<v8::Value>();
}
-BooleanOrString NativeValueTraits<BooleanOrString>::nativeValue(const v8::Local<v8::Value>& value, v8::Isolate* isolate, ExceptionState& exceptionState)
+BooleanOrString NativeValueTraits<BooleanOrString>::nativeValue(v8::Local<v8::Value> value, v8::Isolate* isolate, ExceptionState& exceptionState)
{
BooleanOrString impl;
V8BooleanOrString::toImpl(isolate, value, impl, exceptionState);
« no previous file with comments | « Source/bindings/tests/results/modules/UnionTypesModules.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698