DescriptionRevert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #3 id:40001 of https://codereview.chromium.org/998173003/)
Reason for revert:
Speculatively revert for https://crbug.com/467471
Original issue's description:
> Fix heap-use-after-free in WebSocketHost::AddChannel()
>
> WebSocketHost can be deleted in channel_->SendAddChannelRequest() and this
> caused heap-use-after-free when |pending_flow_control_quota_| is accessed in
> WebSocketHost::AddChannel().
> This CL fixes it by posting OnFlowControl() with WeakPtr instead of calling
> SendFlowControl() directly in WebSocketHost::AddChannel().
>
> BUG=466335
>
> Committed: https://crrev.com/d3a1d188162e45f75c87a218a70681c5d92139a8
> Cr-Commit-Position: refs/heads/master@{#320260}
TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335
Committed: https://crrev.com/4f078b9b59cbf2c1ea7098835c6488fa32d46474
Cr-Commit-Position: refs/heads/master@{#320703}
Patch Set 1 #
Created: 5 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|