Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: chrome/browser/extensions/extension_ui_util.h

Issue 1006273002: Show location for bookmark apps that have navigated across origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove change to web app frame applicability Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserContext; 9 class BrowserContext;
10 class WebContents;
10 } 11 }
11 12
12 namespace extensions { 13 namespace extensions {
13 14
14 class Extension; 15 class Extension;
15 16
16 namespace ui_util { 17 namespace ui_util {
17 18
18 // Returns true if the extension should be displayed in the app launcher. 19 // Returns true if the extension should be displayed in the app launcher.
19 // Checks whether the extension is an ephemeral app or should be hidden due to 20 // Checks whether the extension is an ephemeral app or should be hidden due to
(...skipping 19 matching lines...) Expand all
39 bool ShouldDisplayInExtensionSettings(const Extension* extension, 40 bool ShouldDisplayInExtensionSettings(const Extension* extension,
40 content::BrowserContext* context); 41 content::BrowserContext* context);
41 42
42 // Returns true if the extension should not be shown anywhere. This is 43 // Returns true if the extension should not be shown anywhere. This is
43 // mostly the same as the extension being a component extension, but also 44 // mostly the same as the extension being a component extension, but also
44 // includes non-component apps that are hidden from the app launcher and NTP, 45 // includes non-component apps that are hidden from the app launcher and NTP,
45 // as well as ephemeral apps. 46 // as well as ephemeral apps.
46 bool ShouldNotBeVisible(const Extension* extension, 47 bool ShouldNotBeVisible(const Extension* extension,
47 content::BrowserContext* context); 48 content::BrowserContext* context);
48 49
50 // Returns true if the location bar should be shown for |web_contents| when
51 // viewed in the context of the app represented by |extension|..
Lei Zhang 2015/03/17 07:19:56 nit: extra period at the end.
benwells 2015/03/17 10:28:13 Done.
52 bool ShouldShowLocationBar(const Extension* extension,
53 content::WebContents* web_contents);
Lei Zhang 2015/03/17 07:19:56 this can probably be const as well.
benwells 2015/03/17 10:28:13 Done.
54
49 } // namespace ui_util 55 } // namespace ui_util
50 } // namespace extensions 56 } // namespace extensions
51 57
52 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_ 58 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_UI_UTIL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_ui_util.cc » ('j') | chrome/browser/extensions/extension_ui_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698