Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1006253002: Oilpan: have LifetimeNotifier<T> track its observers weakly. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have LifetimeNotifier<T> track its observers weakly. Simplify the unregistration of lifetime observers upon finalization by having LifetimeNotifier<> keep a WeakMember<> reference to them. As a result the observers will no longer have to explicitly unregister themselves when going away. Observers can still explicitly unregister, should that be needed for other reasons. R=haraken BUG=462949, 467502 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192011

Patch Set 1 #

Patch Set 2 : non-oilpan compile fix #

Patch Set 3 : Update MIDIAccessInitializer's prefinalizer unregistration step #

Patch Set 4 : Fill in GC_PLUGIN_IGNORE() #

Total comments: 20

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -33 lines) Patch
M Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.cpp View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
M Source/platform/LifecycleNotifier.h View 1 2 3 2 chunks +11 lines, -2 lines 0 comments Download
M Source/platform/LifecycleObserver.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 25 (6 generated)
sof
please take a look. https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode55 Source/core/dom/ActiveDOMObject.cpp:55: #if !ENABLE(OILPAN) Is this assert ...
5 years, 9 months ago (2015-03-16 15:44:34 UTC) #2
haraken
Thanks for working on this! https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 Source/core/dom/ActiveDOMObject.cpp:51: if (!executionContext()) Is it ...
5 years, 9 months ago (2015-03-16 23:44:22 UTC) #4
sof
https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 Source/core/dom/ActiveDOMObject.cpp:51: if (!executionContext()) On 2015/03/16 23:44:22, haraken wrote: > > ...
5 years, 9 months ago (2015-03-17 06:24:07 UTC) #5
haraken
https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 Source/core/dom/ActiveDOMObject.cpp:51: if (!executionContext()) On 2015/03/17 06:24:06, sof wrote: > On ...
5 years, 9 months ago (2015-03-17 08:29:36 UTC) #6
sof
https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 Source/core/dom/ActiveDOMObject.cpp:51: if (!executionContext()) On 2015/03/17 08:29:36, haraken wrote: > On ...
5 years, 9 months ago (2015-03-17 08:34:42 UTC) #7
haraken
https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp File Source/core/dom/ActiveDOMObject.cpp (right): https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 Source/core/dom/ActiveDOMObject.cpp:51: if (!executionContext()) On 2015/03/17 08:34:42, sof wrote: > On ...
5 years, 9 months ago (2015-03-17 08:36:23 UTC) #8
sof
On 2015/03/17 08:36:23, haraken wrote: > https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp > File Source/core/dom/ActiveDOMObject.cpp (right): > > https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp#newcode51 > ...
5 years, 9 months ago (2015-03-17 08:37:14 UTC) #9
haraken
On 2015/03/17 08:37:14, sof wrote: > On 2015/03/17 08:36:23, haraken wrote: > > > https://codereview.chromium.org/1006253002/diff/60001/Source/core/dom/ActiveDOMObject.cpp ...
5 years, 9 months ago (2015-03-17 08:49:54 UTC) #10
sof
https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h File Source/platform/LifecycleNotifier.h (right): https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h#newcode80 Source/platform/LifecycleNotifier.h:80: // bases, but cannot itself derive from a GC ...
5 years, 9 months ago (2015-03-17 08:51:46 UTC) #11
sof
On 2015/03/17 08:49:54, haraken wrote: > On 2015/03/17 08:37:14, sof wrote: > > On 2015/03/17 ...
5 years, 9 months ago (2015-03-17 08:54:12 UTC) #12
haraken
On 2015/03/17 08:54:12, sof wrote: > On 2015/03/17 08:49:54, haraken wrote: > > On 2015/03/17 ...
5 years, 9 months ago (2015-03-17 09:15:30 UTC) #13
haraken
https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h File Source/platform/LifecycleNotifier.h (right): https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h#newcode37 Source/platform/LifecycleNotifier.h:37: class LifecycleNotifier { On 2015/03/17 08:29:36, haraken wrote: > ...
5 years, 9 months ago (2015-03-17 09:15:36 UTC) #14
haraken
Forgot to say: LGTM.
5 years, 9 months ago (2015-03-17 09:15:49 UTC) #15
sof
https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h File Source/platform/LifecycleNotifier.h (right): https://codereview.chromium.org/1006253002/diff/60001/Source/platform/LifecycleNotifier.h#newcode37 Source/platform/LifecycleNotifier.h:37: class LifecycleNotifier { On 2015/03/17 09:15:36, haraken wrote: > ...
5 years, 9 months ago (2015-03-17 09:28:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006253002/60001
5 years, 9 months ago (2015-03-17 12:42:32 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/31666)
5 years, 9 months ago (2015-03-17 12:48:01 UTC) #20
sof
(Rebased to handle trivial r192001 conflict.)
5 years, 9 months ago (2015-03-17 12:50:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006253002/80001
5 years, 9 months ago (2015-03-17 12:50:42 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 14:20:16 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192011

Powered by Google App Engine
This is Rietveld 408576698