Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: trunk/src/sandbox/linux/seccomp-bpf/sandbox_bpf.cc

Issue 100623014: Revert 240670 "Revert 239894 "Linux Sandbox: check no threads be..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/sandbox/linux/services/broker_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/sandbox/linux/seccomp-bpf/sandbox_bpf.cc
===================================================================
--- trunk/src/sandbox/linux/seccomp-bpf/sandbox_bpf.cc (revision 240957)
+++ trunk/src/sandbox/linux/seccomp-bpf/sandbox_bpf.cc (working copy)
@@ -268,6 +268,10 @@
SANDBOX_DIE("Process started without standard file descriptors");
}
+ // This code is using fork() and should only ever run single-threaded.
+ // Most of the code below is "async-signal-safe" and only minor changes
+ // would be needed to support threads.
+ DCHECK(IsSingleThreaded(proc_fd_));
pid_t pid = fork();
if (pid < 0) {
// Die if we cannot fork(). We would probably fail a little later
« no previous file with comments | « no previous file | trunk/src/sandbox/linux/services/broker_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698