Allow inactive windows to be created with Linux Aura.

ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_root_window_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 317 matching lines @@
 
   desktop_native_widget_aura_->OnHostClosed();
 }
 
 aura::WindowTreeHost* DesktopWindowTreeHostX11::AsWindowTreeHost() {
   return this;
 }
 
 void DesktopWindowTreeHostX11::ShowWindowWithState(
     ui::WindowShowState show_state) {
+  if (window_mapped_)
+    return;
+
   if (show_state != ui::SHOW_STATE_DEFAULT &&
-      show_state != ui::SHOW_STATE_NORMAL) {
-    // Only forwarding to Show().
+      show_state != ui::SHOW_STATE_NORMAL &&
+      show_state != ui::SHOW_STATE_INACTIVE) {
+    // It will behave like SHOW_STATE_NORMAL.
     NOTIMPLEMENTED();
   }
 
-  Show();
+  // Before we map the window, set size hints. Otherwise, some window managers
+  // will ignore toplevel XMoveWindow commands.

[Matt Giuca, 2014/01/13 00:18:57]

Optional nit (I realize you didn't write this): top-level
Also, could you put an (eg, ...) and name a window manager, so this can be
tested?

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

If I knew which WM would ignore the toplevel XMoveWindow, I would gladly :)

+  XSizeHints size_hints;
+  size_hints.flags = PPosition;
+  size_hints.x = bounds_.x();
+  size_hints.y = bounds_.y();
+  XSetWMNormalHints(xdisplay_, xwindow_, &size_hints);
+
+  XWMHints wm_hints;
+  wm_hints.flags = InputHint | StateHint;
+  wm_hints.input = show_state != ui::SHOW_STATE_INACTIVE;

[Matt Giuca, 2014/01/13 00:18:57]

// If SHOW_STATE_INACTIVE, tell the window manager that the window is not
focusable. This will make the window inactive upon creation.

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

Done.

[Matt Giuca, 2014/01/14 05:43:27]

I don't see any such comment?

+  wm_hints.initial_state = NormalState;
+  XSetWMHints(xdisplay_, xwindow_, &wm_hints);
+
+  XMapWindow(xdisplay_, xwindow_);
+
+  // We now block until our window is mapped. Some X11 APIs will crash and
+  // burn if passed |xwindow_| before the window is mapped, and XMapWindow is

[Matt Giuca, 2014/01/13 00:18:57]

Optional nit (I realize you didn't write this): Get rid of "and burn". And if
they do not actually crash, please describe what they actually do.

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

I removed "and burn". I guess those other API calls assume that xwindow is
mapped.

+  // asynchronous.
+  base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_);
+  window_mapped_ = true;
+
+  // The window has been created and mapped. Keeping the hint will simply
+  // confuse the WM at that point.

[Matt Giuca, 2014/01/13 00:18:57]

What does "confuse" mean? Which hint are you referring to? The input=false hint?
Surely that isn't a matter of confusion: if you leave that as false, it won't
work at all.

Or the initial_state hint? I don't see why you remove the initial_state hint if
SHOW_STATE_INACTIVE is true, but otherwise you keep it? Is this a mistake?

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

Updated the comment. There is no need to set |initial_state| given that it does
not change.

+  if (show_state == ui::SHOW_STATE_INACTIVE) {
+    XWMHints wm_hints;
+    wm_hints.flags = InputHint;
+    wm_hints.input = true;

[Matt Giuca, 2014/01/13 00:18:57]

// Tell the window manager that the window is now focusable.

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

Done.

+    XSetWMHints(xdisplay_, xwindow_, &wm_hints);
+  }
+
+  if (show_state != ui::SHOW_STATE_INACTIVE)

[Matt Giuca, 2014/01/13 00:18:57]

How about "else"?

[mlamouri (slow - plz ping), 2014/01/13 02:04:58]

That has changed. It is being taken care of in cl 109433005.

[Matt Giuca, 2014/01/14 05:43:27]

As I wrote on that CL, is this one going first or second? If this one is going
first, then you should fix this now, and then do what you like in the next CL.
If this one is going second, you should base it off the other one so we can
understand what the final result will look like.

+    native_widget_delegate_->AsWidget()->SetInitialFocus();
 }
 
 void DesktopWindowTreeHostX11::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   restored_bounds_ = restored_bounds;
   Maximize();
   Show();
 }
 
 bool DesktopWindowTreeHostX11::IsVisible() const {
@@ skipping 363 matching lines @@
 
 aura::RootWindow* DesktopWindowTreeHostX11::GetRootWindow() {
   return root_window_;
 }
 
 gfx::AcceleratedWidget DesktopWindowTreeHostX11::GetAcceleratedWidget() {
   return xwindow_;
 }
 
 void DesktopWindowTreeHostX11::Show() {
-  if (!window_mapped_) {
-    // Before we map the window, set size hints. Otherwise, some window managers
-    // will ignore toplevel XMoveWindow commands.
-    XSizeHints size_hints;
-    size_hints.flags = PPosition;
-    size_hints.x = bounds_.x();
-    size_hints.y = bounds_.y();
-    XSetWMNormalHints(xdisplay_, xwindow_, &size_hints);
-
-    XMapWindow(xdisplay_, xwindow_);
-
-    // We now block until our window is mapped. Some X11 APIs will crash and
-    // burn if passed |xwindow_| before the window is mapped, and XMapWindow is
-    // asynchronous.
-    base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_);
-    window_mapped_ = true;
-  }
-
-  native_widget_delegate_->AsWidget()->SetInitialFocus();
+  ShowWindowWithState(ui::SHOW_STATE_NORMAL);
 }
 
 void DesktopWindowTreeHostX11::Hide() {
   if (window_mapped_) {
     XWithdrawWindow(xdisplay_, xwindow_, 0);
     window_mapped_ = false;
   }
 }
 
 void DesktopWindowTreeHostX11::ToggleFullScreen() {
@@ skipping 789 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme();
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views