Allow inactive windows to be created with Linux Aura.

ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_root_window_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 312 matching lines @@
 
   desktop_native_widget_aura_->OnHostClosed();
 }
 
 aura::RootWindowHost* DesktopRootWindowHostX11::AsRootWindowHost() {
   return this;
 }
 
 void DesktopRootWindowHostX11::ShowWindowWithState(
     ui::WindowShowState show_state) {
+  if (window_mapped_)
+    return;
+
   if (show_state != ui::SHOW_STATE_DEFAULT &&
-      show_state != ui::SHOW_STATE_NORMAL) {
-    // Only forwarding to Show().
+      show_state != ui::SHOW_STATE_NORMAL &&
+      show_state != ui::SHOW_STATE_INACTIVE) {
+    // It will behave like SHOW_STATE_NORMAL.
     NOTIMPLEMENTED();
   }
 
-  Show();
+  // Before we map the window, set size hints. Otherwise, some window managers
+  // will ignore toplevel XMoveWindow commands.
+  XSizeHints size_hints;
+  size_hints.flags = PPosition;
+  size_hints.x = bounds_.x();
+  size_hints.y = bounds_.y();
+  XSetWMNormalHints(xdisplay_, xwindow_, &size_hints);
+
+  if (show_state == ui::SHOW_STATE_INACTIVE) {
+    XWMHints wm_hints;
+    wm_hints.flags = InputHint;
+    wm_hints.input = false;
+    XSetWMHints(xdisplay_, xwindow_, &wm_hints);

[Elliot Glaysher, 2013/12/10 20:21:55]

While I'm not sure if the use of .input is correct here...

+  }
+
+  XMapWindow(xdisplay_, xwindow_);
+
+  // We now block until our window is mapped. Some X11 APIs will crash and
+  // burn if passed |xwindow_| before the window is mapped, and XMapWindow is
+  // asynchronous.
+  base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_);
+  window_mapped_ = true;
+
+  // The window has been created and mapped. Keeping the hint will simply
+  // confuse the WM at that point.
+  if (show_state == ui::SHOW_STATE_INACTIVE) {
+    XWMHints wm_hints;
+    wm_hints.flags = InputHint;
+    wm_hints.input = true;
+    XSetWMHints(xdisplay_, xwindow_, &wm_hints);

[Elliot Glaysher, 2013/12/10 20:21:55]

I also suspect that we should be setting this all the time. Look at the function
update_wm_hints() in gdk/x11/gdkwindow-x11.c in the gtk source tree.

[mlamouri (slow - plz ping), 2013/12/11 14:58:48]

I guess setting this on the previous call all the time would be better so the
hints are used by the WM before mapping the window. Maybe add a WindowHint about
the window being in a normal state too.

+  }
+
+  if (show_state != ui::SHOW_STATE_INACTIVE)
+    native_widget_delegate_->AsWidget()->SetInitialFocus();
 }
 
 void DesktopRootWindowHostX11::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   restored_bounds_ = restored_bounds;
   Maximize();
   Show();
 }
 
 bool DesktopRootWindowHostX11::IsVisible() const {
@@ skipping 357 matching lines @@
 
 aura::RootWindow* DesktopRootWindowHostX11::GetRootWindow() {
   return root_window_;
 }
 
 gfx::AcceleratedWidget DesktopRootWindowHostX11::GetAcceleratedWidget() {
   return xwindow_;
 }
 
 void DesktopRootWindowHostX11::Show() {
-  if (!window_mapped_) {
-    // Before we map the window, set size hints. Otherwise, some window managers
-    // will ignore toplevel XMoveWindow commands.
-    XSizeHints size_hints;
-    size_hints.flags = PPosition;
-    size_hints.x = bounds_.x();
-    size_hints.y = bounds_.y();
-    XSetWMNormalHints(xdisplay_, xwindow_, &size_hints);
-
-    XMapWindow(xdisplay_, xwindow_);
-
-    // We now block until our window is mapped. Some X11 APIs will crash and
-    // burn if passed |xwindow_| before the window is mapped, and XMapWindow is
-    // asynchronous.
-    base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_);
-    window_mapped_ = true;
-  }
-
-  native_widget_delegate_->AsWidget()->SetInitialFocus();
+  ShowWindowWithState(ui::SHOW_STATE_NORMAL);

[mlamouri (slow - plz ping), 2013/12/11 14:58:48]

I realise that ::Show() is actually expecting to not activate the window. See
Widget::Show(). I will fix that.

 }
 
 void DesktopRootWindowHostX11::Hide() {
   if (window_mapped_) {
     XWithdrawWindow(xdisplay_, xwindow_, 0);
     window_mapped_ = false;
   }
 }
 
 void DesktopRootWindowHostX11::ToggleFullScreen() {
@@ skipping 789 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme();
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views